Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: return projection matrix for hypertools.tools.procrustes? #217

Open
hungtuchen opened this issue Aug 6, 2018 · 3 comments

Comments

@hungtuchen
Copy link

In current implementation of hypertools.tools.procrustes, it only returns the aligned source matrix.
I think it would be great if we can return the projection matrix so that we can use it to transform other data.

I am thinking (1) returning as a second output parameter (2) adding an option to let user choose if the projection matrix should be return (maybe default: False)

@hungtuchen
Copy link
Author

If we agree on a solution, I am glad to work on it and submit a PR.

@andrewheusser
Copy link
Collaborator

@transedward - It's a good idea, but part of a larger revamping that would be required to keep the API consistent across all transformers (e.g. alignment, reduction etc). The way we've talked about doing this is saving out the entire transformation pipeline of fit models inside of a geo (the data object returned when hyp.plot() is called). Currently, the steps are saved, but the fit models are not.

Would you be interested in helping out with this? I think we have an existing issue with more details, let me see if I can find it..

@andrewheusser
Copy link
Collaborator

here's the issue: #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants