Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support DuckDB 1.0 #590

Closed
cdeil opened this issue Jul 6, 2024 · 3 comments
Closed

Please support DuckDB 1.0 #590

cdeil opened this issue Jul 6, 2024 · 3 comments

Comments

@cdeil
Copy link

cdeil commented Jul 6, 2024

DuckDB released version 1.0 ( see HERE) which we are using in our project.

You are currently forcing DuckDB 0.10 here:

"duckdb>=0.10.1,<0.11.0",

and when I ran pip install pygwalker to use it for exploratory analysis this downgraded and installed the old DuckDB you are requiring currently.

I think DuckDB didn't change much between 0.10 and 1.0 and they almost never break backward compatibility. Could you please try to remove the upper bound and support use DuckDB 1.0 together with PygWalker?

Please, please, please ... :-)

@longxiaofei
Copy link
Member

pygwalker 0.4.9.1 already support duckdb 1.0.0.

@cdeil
Copy link
Author

cdeil commented Jul 7, 2024

@longxiaofei - thank you!

I see you did this 0b4df99

This means you constantly have to chase every major/minor/bugfix release of DuckDB to allow DuckDB users to install it with pygwalker (unless they know how to override your version constraint which is what I did yesterday when I ran into this issue).

I think if you simply did duckdb>=0.10.1 removing the upper version constraint that would be the normal thing what most packages do, or if you want to be on the safe side for possible breaking releases in future years then duckdb>=0.10.1,<=2 would be better.

Note that for me and I think most pygwalker users it's just one out of 10s of packages I use, and where then I simply take care of locking versions to get reproducible/working set. So any package like pygwalker here that puts version contraints that are more tight than needed quickly leeds to the situation that no compatible set exists (imagine some other package I want to use requires duckdb>=1.1 in the next months).

@longxiaofei
Copy link
Member

Hi @cdeil

I agree with your point.

Previously, the upgrade from DuckDB 0.8 to 0.9 caused some commonly used features in PyGWalker to stop working.

As a result, we had to restrict the DuckDB version and were cautious about updating it.

Now, it seems that DuckDB has become more stable.

In the next version of PyGWalker, we plan to remove the version restriction on DuckDB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants