Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is the # title in the SPARQL queries meant to be used by the WDQS? #2304

Open
egonw opened this issue Jul 21, 2023 · 4 comments · May be fixed by #2307
Open

is the # title in the SPARQL queries meant to be used by the WDQS? #2304

egonw opened this issue Jul 21, 2023 · 4 comments · May be fixed by #2307
Assignees
@egonw
Labels
question something looking for an answer

Comments

@egonw
Copy link
Collaborator

egonw commented Jul 21, 2023 •
edited
Loading

Context

Multiple SPARQL queries have a title in a comment, e.g.

scholia/scholia/app/templates/venue_topics.sparql

Line 1 in 6d14811

# title: Count of topics in published work in specified venue

But many of # title: which is not recognized by the WDQS, while #title: is (see below screenshots).

The space is quite prevalent.

Question

Is the use of #title: in the queries meant to be used by the WDQS?

Screenshots

With space:

image

Without space:

image
@egonw egonw added the question something looking for an answer label Jul 21, 2023
@Daniel-Mietchen
Copy link
Member

I think these should be without space, so as to give the blue ribbon atop of the results.
Some of those with space might be older than that WDQS feature.

@egonw
Copy link
Collaborator Author

egonw commented Jul 21, 2023

Okay, I will go ahead and make a patch then.

@egonw egonw assigned egonw and unassigned Daniel-Mietchen and fnielsen Jul 21, 2023
@egonw egonw linked a pull request Jul 22, 2023 that will close this issue
Open
9 tasks
@fnielsen
Copy link
Collaborator

If I remember correctly, I added the "title" before Wikimedia (in Berlin?) started to use the keyword (without the space). I do not think we should use title because the iframes would then get a title banner which might not be visually nice on the scholia page. The "tool" keyword is added automagically. We could suggest that this becomes a Wikimedia keyword.

@egonw
Copy link
Collaborator Author

egonw commented Jul 27, 2023 •
edited
Loading

I do not think we should use title because the iframes would then get a title banner

Good point! I agree with that. We can remove that line when used in the iframe context, just like we add the #tool: line. Would that be an idea? Then when you open it with 'edit' in WDQS, then the title would be there (handy when people want to bookmark a particular query (for some Scholia/Wikidata item).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egonw egonw

Labels
question something looking for an answer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WDQS-compatible titles egonw/scholia
3 participants
@egonw @Daniel-Mietchen @fnielsen