Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform should validate an entered cron expression to align frontend and backend error handling #40715

Open
hongbo-miao opened this issue Jul 3, 2024 · 1 comment

Comments

@hongbo-miao
Copy link
Contributor

hongbo-miao commented Jul 3, 2024

Topic

airbyte-webapp

Relevant information

Currently 0 0 15 * * 1 shows valid in the UI, but it is not.
The good thing is when you click "save changes", it shows invalid.

The correct one is 0 0 15 ? * 1.

It will be great to let the UI shows invalid for 0 0 15 * * 1 as well. 😃

image

https://www.javainuse.com/cron is good resource to validate whether it is actually valid.

You can see 0 0 15 * * 1 is invalid:
image

You can see 0 0 15 ? * 1 is invalid:

image

@hongbo-miao hongbo-miao changed the title 0 0 15 * * 1 should be not be valid cron schedule in the Airbyte UI 0 0 15 * * 1 should not show valid for cron schedule in the Airbyte UI Jul 3, 2024
@nataliekwong
Copy link
Contributor

nataliekwong commented Jul 3, 2024

The frontend sees this as valid but the backend does not. One solution would be to create a backend endpoint that validates the cron, and only show the preview if the validation passes.

Internal issue with additional user feedback: https://github.com/airbytehq/airbyte-internal-issues/issues/5069

@nataliekwong nataliekwong changed the title 0 0 15 * * 1 should not show valid for cron schedule in the Airbyte UI Platform should validate an entered cron expression to align Frontend/Backend error handling Jul 3, 2024
@hongbo-miao hongbo-miao changed the title Platform should validate an entered cron expression to align Frontend/Backend error handling Platform should validate an entered cron expression to align frontend and backend error handling Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants