Added priority to Azure Container Instances #40616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
We need a unit test to be added alongside the change. |
|
Sorry about that, I've added a unit test for priority = "Spot", do I need another for priority = "Regular"? |
potiuk
approved these changes
Jul 9, 2024
|
good enough :) |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jul 13, 2024
The apache#40616 used priority for ContainerGroup and it has only been added in 10.1.0 version of azure-containerinstance library See https://pypi.org/project/azure-mgmt-containerinstance/10.1.0/
potiuk
added a commit
that referenced
this pull request
Jul 13, 2024
The #40616 used priority for ContainerGroup and it has only been added in 10.1.0 version of azure-containerinstance library See https://pypi.org/project/azure-mgmt-containerinstance/10.1.0/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add priority to Container Instances on Azure
This commit adds a priority setting to Azure Container Instances. By default, the priority is set to "Regular", but it can be set to "Spot" for less time-sensitive tasks to take advantage of spot pricing.
closes: #40574
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.