Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch HttpHook from using requests library to httpx? #40580

Open
1 of 2 tasks
kiaradlf opened this issue Jul 3, 2024 · 1 comment
Open
1 of 2 tasks

switch HttpHook from using requests library to httpx? #40580

kiaradlf opened this issue Jul 3, 2024 · 1 comment
Labels
kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet pending-response provider:http

Comments

@kiaradlf
Copy link

kiaradlf commented Jul 3, 2024

Description

the HttpHook currently uses the requests library for HTTP calls.
httpx appears a more modern alternative, boasting support for e.g. http2, async support, and type annotations.
it would be nice if the http hook could perhaps take advantage of these as well.

Use case/motivation

my own immediate use-case was password-protected client certificates, which seem not supported in requests.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@kiaradlf kiaradlf added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Jul 3, 2024
@dosubot dosubot bot added the provider:http label Jul 3, 2024
@potiuk
Copy link
Member

potiuk commented Jul 3, 2024

I am not sure we recently switched back from httpx to requests in file task handler, because it did not work with some specific NO_PROXY settings #39799. And since HTTPHook is just simple wrapper and has simple functionality - we do not need all the "fancy" features httpx has. But if someone (like you) take on the task to make sure to handle the issues like the one in #39799 - then why not - with documentation etc.

We need someone to take a lead, analyse all pros and cons and things supported/not supported by both and come up with good documentation.

Would you like to take a lead on that one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet pending-response provider:http
Projects
None yet
Development

No branches or pull requests

2 participants