@utin-francis-peter is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

The latest updates on your projects. Learn more about Vercel for Git ↗︎

hi @utin-francis-peter
The PR looks good, just a few comments.

• Do you think instead of hasSilverBorder prop could there be a variant defined like an enum to choose from.
  Could checkout the AntD props for Input component as a reference maybe (https://ant.design/components/input)

• Noticed this small resize issue when changing screen dimensions
  https://github.com/arc53/DocsGPT/assets/47355538/4150a775-49e9-4c5e-b86e-faee4b5c86f5

Thanks for the review, @siiddhantt.

Based on the current design, hasSilverBorder prop encapsulates border-silver dark:border-silver/40 styles. There's also a border-jet border-b-2 and border-gray-5000 dark:text-silver that isn't accounted for yet with props as they're not used in multiple locations yet.

Considering these, what options do you propose for the variant prop? Also, would you advise a camelCase or ALLCAPS style be used for the options so they act as an enum?

Considering these, what options do you propose for the variant prop?

@utin-francis-peter would something like variant?: 'silver' | 'jet' | 'gray'; be good just for the border color? Something like that maybe.

Considering these, what options do you propose for the variant prop?

@utin-francis-peter would something like variant?: 'silver' | 'jet' | 'gray'; be good just for the border color? Something like that maybe.

It does sound cool.

Perhaps the prop could be colorVariant instead?

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.83%. Comparing base (5aa8871) to head (d554444).
Report is 19 commits behind head on main.

@@           Coverage Diff           @@
##             main    #1027   +/-   ##
=======================================
  Coverage   21.83%   21.83%           
=======================================
  Files          80       80           
  Lines        3645     3645           
=======================================
  Hits          796      796           
  Misses       2849     2849           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

One note before merging, is lets not create a component for input box from conversation.tsx for a few reasons:

1. Its better to create separate component for it if it will be needed
2. We keep our normal input box cleaner and easily reusable
3. Will create conflicts with other PR's that are currently active

So in a scope of this PR, lets not touch conversation.tsx

Thank you!
Kind Regards,
Alex

One note before merging, is lets not create a component for input box from conversation.tsx for a few reasons:

1. Its better to create separate component for it if it will be needed
2. We keep our normal input box cleaner and easily reusable
3. Will create conflicts with other PR's that are currently active

So in a scope of this PR, lets not touch conversation.tsx

Thank you! Kind Regards, Alex

Hi, Alex.

During the first iteration I created a TextInput component which rendered a textarea element. While attempting to use it across the application, I noticed I was over-engineering and stopped.

In the next iteration I created separate custom Input and TextArea components for separation of concerns. The Input replaced all input elements, while the TextArea replaced the div contentEditable in Conversation.tsx file.

Do I move out TextArea component and its use in the Conversations.tsx file into a seperate PR?

Yes, lets move it for now as we have few PR's open that will change it.
We can make those changes later on once all pr relating to that TextArea are mergerd.
Ill give you a ping

Yes, lets move it for now as we have few PR's open that will change it. We can make those changes later on once all pr relating to that TextArea are mergerd. Ill give you a ping

Please a quick one, Alex:

Do I leave the textArea component and its type definition as it is in the branch; but not use the component in the Conversations.tsx file?

So it's there but not used in the specified file until all PRs using the current div contentEditable are closed?

Just don't use textArea yet, you can remove it in this pr for now

Thank you!

I missed it myself, seems like we have 1 warning
src/components/TextArea.tsx(2,10): error TS2305: Module '"./types"' has no exported member 'TextAreaProps'.

I missed it myself, seems like we have 1 warning src/components/TextArea.tsx(2,10): error TS2305: Module '"./types"' has no exported member 'TextAreaProps'.

Arrgggghh.

So sorry, Alex.

No worries at all!