Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Misaligned Submit Button in Query Bar #1023

Closed
2 tasks done
shelar1423 opened this issue Jul 2, 2024 · 9 comments · Fixed by #1028
Closed
2 tasks done

🐛 Bug Report: Misaligned Submit Button in Query Bar #1023

shelar1423 opened this issue Jul 2, 2024 · 9 comments · Fixed by #1028
Labels
frontend good first issue Good for newcomers help wanted Extra attention is needed javascript Pull requests that update Javascript code

Comments

@shelar1423
Copy link
Collaborator

📜 Description

the submit button in the query bar appears misaligned within its container. This misalignment affects the visual aesthetics and usability of the query bar.

👟 Reproduction steps

  1. Navigate to the interface with the query bar and hover upon it.
  2. Observe the submit button within the query bar.

👍 Expected behavior

The submit button should be perfectly centered and aligned within its circular container, ensuring a clean and user-friendly appearance.

👎 Actual Behavior with Screenshots

image

💻 Operating system

Windows

What browsers are you seeing the problem on?

Chrome

🤖 What development environment are you experiencing this bug on?

Docker

🔒 Did you set the correct environment variables in the right path? List the environment variable names (not values please!)

No response

📃 Provide any additional context for the Bug.

No response

📖 Relevant log output

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🔗 Are you willing to submit PR?

None

🧑‍⚖️ Code of Conduct

  • I agree to follow this project's Code of Conduct
@shelar1423 shelar1423 added good first issue Good for newcomers frontend labels Jul 2, 2024
@dartpain dartpain added help wanted Extra attention is needed javascript Pull requests that update Javascript code labels Jul 2, 2024
@sarthaklaptop
Copy link

sarthaklaptop commented Jul 2, 2024

Is this issue still open ?
Screenshot from 2024-07-02 22-28-45
for me the submit button is perfectly centered in laptop and mobile screen

@blackviking27
Copy link
Contributor

This icon is perfectly aligned but visually it seems a little off. adding a little padding / margin on left and adjusting the icon width will center the icon visually which can be seen in the below diagram.

search-center

@shelar1423
Copy link
Collaborator Author

Is this issue still open ?
Screenshot from 2024-07-02 22-28-45
for me the submit button is perfectly centered in laptop and mobile screen

Yes it is open,you can try to make it a bit more aligned visually as it requires some padding

@nayelimdejesus
Copy link

Hi, I would like to work on this issue.

@utin-francis-peter
Copy link
Contributor

utin-francis-peter commented Jul 3, 2024

@shelar1423 @blackviking27 Please have a look at the linked PR and share your thoughts.

Thank you.

@blackviking27
Copy link
Contributor

@utin-francis-peter I looked at your css changes and would like to point out that the Icon still seems a little off. I added some of my css changes to visually align the icon to center. You can see the difference below

your css
search-center

adding only ml-[4px] h-6 classes to the img tag
correct-search

I hope you can see the differences, You can implement these changes or try something new. Hope this helps

@utin-francis-peter
Copy link
Contributor

The all mighty CSS at it again, lol.

@blackviking27 I've modified the styles using the highlighted classes. Pls have a look.

Thanks.

@blackviking27
Copy link
Contributor

@utin-francis-peter Looks pretty good now. Don't see the need to add flex-shrink-0 and also p-4 would align better with border of the input text.

@chickenleaf
Copy link

@blackviking27 hello!! is this still up for grabs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend good first issue Good for newcomers help wanted Extra attention is needed javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants