Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parameter when creating vocabularies in sockeye.train.create_data_iters_and_vocabs #1113

Open
iPRET opened this issue May 31, 2024 · 0 comments

Comments

@iPRET
Copy link

iPRET commented May 31, 2024

I think I found a bug in the sockeye.train.create_data_iters_and_vocabs function.

If I understand the code correctly, I suspect lines 388 and 390 should be:
source_factor_vocab_same_as_source=args.source_factors_use_source_vocab and
target_factor_vocab_same_as_target=args.target_factors_use_target_vocab,
rather than what they are now. (҂◡_◡)
image

Is that correct?
Thanks!
I.P.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant