Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get_historcial HTTPError 404 On days market was closed #35

Open
samuelhopkins opened this issue Apr 2, 2015 · 3 comments
Open

Get_historcial HTTPError 404 On days market was closed #35

samuelhopkins opened this issue Apr 2, 2015 · 3 comments

Comments

@samuelhopkins
Copy link

An attempt to get historical data from a weekday when the market was closed, for example national holidays, results in a 404 error from urllib. It would probably be better to catch the error and return an empty dict.
@BChip
Copy link

BChip commented Apr 27, 2015

Fixed

@cgoldberg
Copy link
Owner

send a pull request

@BChip
Copy link

BChip commented Apr 27, 2015

Pull Request Sent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cgoldberg @samuelhopkins @BChip