Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream autolinking improvements to React Native Core #45302

Closed
szymonrybczak opened this issue Jul 5, 2024 · 9 comments
Closed

Upstream autolinking improvements to React Native Core #45302

szymonrybczak opened this issue Jul 5, 2024 · 9 comments
Assignees
@cortinico
Labels
API: Linking p: Callstack Partner: Callstack Partner Resolution: PR Submitted A pull request with a fix has been provided.

Comments

@szymonrybczak
Copy link
Contributor

szymonrybczak commented Jul 5, 2024 •
edited
Loading

Description

Recently we've landed few improvements to autolinking mechanism, but since autolinking was moved to Core we need to replicate these fixes:

cc: @cortinico
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

⚠️ Missing Reproducible Example
ℹ️ We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

@github-actions github-actions bot added Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. API: Linking labels Jul 5, 2024
@atlj atlj mentioned this issue Jul 5, 2024
Closed
@cortinico cortinico added Resolution: PR Submitted A pull request with a fix has been provided. and removed Needs: Triage 🔍 Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. labels Jul 8, 2024
cortinico added a commit to cortinico/react-native that referenced this issue Jul 8, 2024
@cortinico @facebook-github-bot
Upstream CLI autolinking changes to RNGP
72d1753 
Summary:
Fixes facebook#45302

I'm ustreaming two changes that happened inside the CLI/Autolinking logic that are
missing inside core autolinking.

Changelog:
[Internal] [Changed] - Upstream CLI autolinking changes to RNGP

Differential Revision: D59460504
@cortinico cortinico mentioned this issue Jul 8, 2024
Closed
@cortinico
Copy link
Contributor

Hey @szymonrybczak, so I could easily upstream react-native-community/cli#2387

The other PR however is a bit more complicated (react-native-community/cli#2379). The reason is that by default, the Android template will invoke npx @react-native-community/cli config --platform "android".

As --platform "android" got added only in the latest alpha, this is causing a failure on CI. I need to get back to it in the future

@cortinico cortinico self-assigned this Jul 8, 2024
cortinico added a commit to cortinico/react-native that referenced this issue Jul 8, 2024
@cortinico @facebook-github-bot
Upstream CLI autolinking changes to RNGP (facebook#45314)
84d0382 
Summary:
Pull Request resolved: facebook#45314

Fixes facebook#45302

I'm ustreaming two changes that happened inside the CLI/Autolinking logic that are
missing inside core autolinking.

Changelog:
[Internal] [Changed] - Upstream CLI autolinking changes to RNGP

Reviewed By: blakef

Differential Revision: D59460504
cortinico added a commit to cortinico/react-native that referenced this issue Jul 8, 2024
@cortinico @facebook-github-bot
Upstream CLI autolinking changes to RNGP (facebook#45314)
b256b91 
Summary:
Pull Request resolved: facebook#45314

Fixes facebook#45302

I'm ustreaming two changes that happened inside the CLI/Autolinking logic that are
missing inside core autolinking.

Changelog:
[Internal] [Changed] - Upstream CLI autolinking changes to RNGP

Reviewed By: blakef

Differential Revision: D59460504
@szymonrybczak
Copy link
Contributor Author

As --platform "android" got added only in the latest alpha, this is causing a failure on CI. I need to get back to it in the future

But we can land this change in main so it'll wait for 0.76 release, right? We don't need to backport it

@cortinico
Copy link
Contributor

But we can land this change in main so it'll wait for 0.76 release, right? We don't need to backport it

@szymonrybczak I'm not sure I follow you

@szymonrybczak
Copy link
Contributor Author

@cortinico Hm, maybe I didn't understand.

As --platform "android" got added only in the latest alpha, this is causing a failure on CI. I need to get back to it in the future

If latest main is using latest alpha release of CLI why CI is failing when providing --platform flag for config?

@cortinico
Copy link
Contributor

If latest main is using latest alpha release of CLI why CI is failing when providing --platform flag for config?

That's a good question :) not sure why it's failing

@szymonrybczak
Copy link
Contributor Author

@cortinico could you send me a job that failed, I can take a look :)

@cortinico cortinico mentioned this issue Jul 10, 2024
Open
cortinico added a commit to cortinico/react-native that referenced this issue Jul 10, 2024
@cortinico @facebook-github-bot
Add --platform android to default config invocation for autolinking
981c9e7 
Summary:
This is a followup for facebook#45302

Changelog:
[Internal] [Changed] - Add --platform android to default config invocation for autolinking

Differential Revision: D59577996
@cortinico
Copy link
Contributor

@szymonrybczak here it is: #45360
Agree that error message is not ideal, this should improve it #45333

@szymonrybczak
Copy link
Contributor Author

@cortinico thank you for working on these! 🙏

github-actions bot pushed a commit to cortinico/react-native that referenced this issue Jul 11, 2024
@cortinico
Add --platform android to default config invocation for autolinking
f10679e 
Summary:
This is a followup for facebook#45302

Changelog:
[Internal] [Changed] - Add --platform android to default config invocation for autolinking

Differential Revision: D59577996
blakef pushed a commit that referenced this issue Jul 15, 2024
@cortinico @blakef
Upstream CLI autolinking changes to RNGP (#45314)
c45d450 
Summary:
Pull Request resolved: #45314

Fixes #45302

I'm ustreaming two changes that happened inside the CLI/Autolinking logic that are
missing inside core autolinking.

Changelog:
[Internal] [Changed] - Upstream CLI autolinking changes to RNGP

Reviewed By: blakef

Differential Revision: D59460504

fbshipit-source-id: a6e7ab6a46fec26620dc965e77b13fdeba84fae3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cortinico cortinico

Labels
API: Linking p: Callstack Partner: Callstack Partner Resolution: PR Submitted A pull request with a fix has been provided.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upstream CLI autolinking changes to RNGP cortinico/react-native
3 participants
@cortinico @facebook-github-bot @szymonrybczak