Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing_extensions missing in requirements #275

Closed
t1h0 opened this issue Jul 6, 2024 · 1 comment
Closed

typing_extensions missing in requirements #275

t1h0 opened this issue Jul 6, 2024 · 1 comment

Comments

@t1h0
Copy link
Contributor

t1h0 commented Jul 6, 2024

8e95c71 added usage of typing_extensions to pipeline.py. Specifically, cast() is used which is only available in typing_extensions>=4.7.0. As typing_extensions is not a requirement to news-please, the solution to the issue is one of the following pull requests:

or

EDIT: Newspaper4k (required by news-please) runs on python 3.8+. news-please should therefore be raised to 3.8 anyway so the first solution might be the best one.

@fhamborg
Copy link
Owner

fhamborg commented Jul 8, 2024

thanks! fixed it with the help of your changes from #276

@fhamborg fhamborg closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants