Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: is it ok to continue after OOM error from encode #441

Open
JackKCWong opened this issue Feb 5, 2024 · 0 comments
Open

Question: is it ok to continue after OOM error from encode #441

JackKCWong opened this issue Feb 5, 2024 · 0 comments

Comments

@JackKCWong
Copy link

I run a sentence-transformer in a http service to serve requests. And I've ran into OOM a few times during encode and noticed that it returns an error instead of panicing.
My experience in Java tells me that it's difficult to recover from OOM so the service may as well just crash. But this lib has chosen to return an error, I wonder if it has taken precausion (e.g. to check available memory before allocating), hence my silly question: is it ok to use the model instance to encode again after OOM in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant