Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug - I think] data_seed in TrainingArguments is unused #31818

Open
2 of 4 tasks
RylanSchaeffer opened this issue Jul 6, 2024 · 0 comments
Open
2 of 4 tasks

[Bug - I think] data_seed in TrainingArguments is unused #31818

RylanSchaeffer opened this issue Jul 6, 2024 · 0 comments
Labels

Comments

@RylanSchaeffer
Copy link

RylanSchaeffer commented Jul 6, 2024

System Info

  • transformers version: 4.42.3
  • Platform: Linux-5.4.0-162-generic-x86_64-with-glibc2.31
  • Python version: 3.12.4
  • Huggingface_hub version: 0.23.4
  • Safetensors version: 0.4.3
  • Accelerate version: 0.32.1
  • Accelerate config: not found
  • PyTorch version (GPU?): 2.3.1+cu121 (True)
  • Tensorflow version (GPU?): not installed (NA)
  • Flax version (CPU?/GPU?/TPU?): not installed (NA)
  • Jax version: not installed
  • JaxLib version: not installed
  • Using distributed or parallel set-up in script?: No
  • Using GPU in script?: Yes
  • GPU type: NVIDIA A100-SXM4-80GB

Who can help?

@muellerzr @SunMarc

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

  1. Run this simple script https://github.com/huggingface/trl/blob/main/examples/scripts/reward_modeling.py, sweeping data_seed e.g., --data_seed=0 for one run, --data_seed=1 for another run.

Expected behavior

I would expect data_seed to make a difference. However, it does not:

image

I opened an issue with TRL but after looking at transformers more closely, I can't actually find where data_seed is used. Could someone please check whether data_seed is actually used?

@RylanSchaeffer RylanSchaeffer changed the title [Potential Bug] data_seed in TrainingArguments is unused (I think) [Bug - I think] data_seed in TrainingArguments is unused Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants