Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI retry failed request and don't cancel entire flow on error #5839

Closed
zackpollard opened this issue Dec 18, 2023 · 2 comments · Fixed by #10750
Closed

CLI retry failed request and don't cancel entire flow on error #5839

zackpollard opened this issue Dec 18, 2023 · 2 comments · Fixed by #10750
Assignees
@etnoy
Labels
cli Tasks related to the Immich CLI enhancement New feature or request feature

Comments

@zackpollard
Copy link
Contributor

Currently the CLI will error and cancel the whole process if one request fails. We should probably instead retry a couple of times and then log an error that the asset failed, but continue on to other assets.
@zackpollard zackpollard added enhancement New feature or request feature cli Tasks related to the Immich CLI labels Dec 18, 2023
@etnoy etnoy self-assigned this Dec 18, 2023
@masterT
Copy link
Contributor

masterT commented Jun 15, 2024

This is particularly annoying when uploading a lot of assets. Was there any progress toward this issue?

@masterT
Copy link
Contributor

masterT commented Jun 18, 2024

A significant improvement could be using an in-memory queue system (e.g., fastq) and having the ability to retry not just failed asset uploads but also other parts of the CLI.

I'm trying to upload an extensive library, and I have all kinds of network errors (I'm hosted with PikaPod, and my instance sometimes restarts, which makes the whole process crash).

I think I will craft a draft for this and open a PR.

@masterT masterT mentioned this issue Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etnoy etnoy

Labels
cli Tasks related to the Immich CLI enhancement New feature or request feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): use a queue for duplicate and upload masterT/immich
3 participants
@etnoy @zackpollard @masterT