Income Report & Recurring Invoice

[chandachewe10]

Describe the bug

1. When you go on reports->income on the right bottom column the income is being added twice to the bottom total. Suppose I have $10,000 income and maybe $15000 revenue, instead of getting a total sum of $25000 I will get $35,000 as the total income. This is occurring on the right bottom column of the total on incomes.

2. The Recurring Income is not being added to the incomes report. Suppose I have another recurring income from company B of $1800. It will not be shown on the total income report

Can you reproduce this on the demo at demo.itflow.org

1. For part 1 the demo is working working fine. For part two No. It can be reproduced

Are you on the latest available version of ITFlow, with an up-to-date database structure?
Yes

To Reproduce
Steps to reproduce the behavior:

1. Add any recurring income for August for example with a category of 'RENTALS'
2. Go on reports->Recurring Income By Clients (It will be shown)
3. Go on reports->income check the income from the category of 'RENTALS' and check the month of august. The recurring income will not be added and shown on the list.4.
4. See error

Expected behavior
I expect the recurring monthly income to be added to incomes of that particular month

Screenshots
The screen shots attached here is for income being added twice to the bottom right total income

Additional context
Add any other context about the problem here.

--

To privately discuss a security issue, please see https://github.com/itflow-org/itflow/security

[johnnyq]

For Part 2: this is intended as the income report only counts payments and revenues received.
As soon as a payment is received for a recurring invoice only then will it be calculated in the income report.
so to clarify Income report does not count future recurring invoices as income until its payed.

Ill look further into Part 1

Thank you for reporting.

[johnnyq]

To also note on this:
We do have a report to see all recurring income that has not been sent or payed calculated in a report recurring income by client.

Perhaps We can have a separate report called Projected Recurring Income that only shows the recurring invoices

[chandachewe10]

For Part 2: this is intended as the income report only counts payments and revenues received. As soon as a payment is received for a recurring invoice only then will it be calculated in the income report. so to clarify Income report does not count future recurring invoices as income until its payed.

Ill look further into Part 1

Thank you for reporting.

Ah gotch you, makes sense. Confirm for part 1 and whether a PR will be necessary or its something you can work on quickly