Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse Matrix Compatibility and Optimized Vector Functions #8

Open
jknix opened this issue Oct 8, 2019 · 3 comments
Open

Sparse Matrix Compatibility and Optimized Vector Functions #8

jknix opened this issue Oct 8, 2019 · 3 comments

Comments

@jknix
Copy link

jknix commented Oct 8, 2019

Hey @joewandy, I've got a fork of this repo out for a project I'm working on, would you be open to me:

  1. Adding python 3 support?
  2. Optimizing some functions to use more efficient sparse arrays + vector operations in a few places? In my tinkering I'm getting a lot better performance

and then putting a PR back in?

@jknix jknix changed the title Numpy Compatibility and Optimized Vector Functions Sparse Matrix Compatibility and Optimized Vector Functions Oct 8, 2019
@jknix
Copy link
Author

jknix commented Oct 8, 2019

Follow on, I'd also like to let the initial Hierarchical LDA object accept an initialized sklearn CountVectorizer object, that'd be a great compatibility.

@joewandy
Copy link
Owner

Sorry for the late reply (I'm travelling). I'd gladly accept any PR from you. Thank you so much for the contribution!!

@jknix
Copy link
Author

jknix commented Oct 11, 2019

Thanks @joewandy! I can't devote a ton of time, so don't expect anything immediate, but I'm making slow and steady progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants