FEAT-#7331: Initial Polars API #7332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a polars namespace to Modin, and the DataFrame and Series objects and their respective APIs. This doesn't include error handling and is still missing several polars features: * LazyFrame * Expressions * String, Temporal, Struct, and other Series accessors * Several parameters * Operators that we don't have query compiler methods for * e.g. sin, cos, tan, etc. Those will be handled in a future PR. Signed-off-by: Devin Petersohn <[email protected]>
devin-petersohn
requested review from
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
anmyachev,
dchigarev and
a team
as code owners
Signed-off-by: Devin Petersohn <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
| def __eq__(self, other) -> "BasePolarsDataset": | ||
| return self.__constructor__( | ||
| _query_compiler=self._query_compiler.eq( | ||
| other._query_compiler if hasattr(other, "_query_compiler") else other |
There was a problem hiding this comment.
optional comment: Why look for query_compiler instead of checking whether other is a BasePolarsDataset?
| Returns: | ||
| Arrow representation of the DataFrame. | ||
| """ | ||
| return polars.from_pandas(self._query_compiler.to_pandas()).to_arrow() |
There was a problem hiding this comment.
optional nit: should we add a _to_polars() to alias polars.from_pandas(self._query_compiler.to_pandas())?
There was a problem hiding this comment.
And should we replace all the polars.from_pandas(self._query_compiler.to_pandas()) here with self._to_polars()?
modin/polars/dataframe.py
Outdated
|
|
||
| groupby = group_by | ||
|
|
||
| def drop(self, *columns): |
There was a problem hiding this comment.
nit: this is missing strict.
Co-authored-by: Mahesh Vashishtha <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
| Returns: | ||
| Arrow representation of the DataFrame. | ||
| """ | ||
| return polars.from_pandas(self._query_compiler.to_pandas()).to_arrow() |
There was a problem hiding this comment.
And should we replace all the polars.from_pandas(self._query_compiler.to_pandas()) here with self._to_polars()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a polars namespace to Modin, and the DataFrame and Series objects and their respective APIs.
This PR adds the following to Modin:
modin.polars.DataFramemodin.polars.Seriesmodin.polars.GroupByThis PR does NOT include matching error handling and is still missing several polars features:
These features will be added in a future PR.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date