Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: keep_default_dates and convert_dates in read_json #59161

Open
mroeschke opened this issue Jul 1, 2024 · 1 comment
Open

DEPR: keep_default_dates and convert_dates in read_json #59161

mroeschke opened this issue Jul 1, 2024 · 1 comment
Labels
Deprecate Functionality to remove in pandas Dtype Conversions Unexpected or buggy dtype conversions IO JSON read_json, to_json, json_normalize

Comments

@mroeschke
Copy link
Member

read_json has convert_dates, keep_default_dates and dtypes that all try to perform dtype conversions on the result from the ujson parser. Conflicts can arise when a column matching the specification of keep_default_dates matches a column specified in dtypes.

The proposal is to deprecate keep_default_dates and convert_dates and only use dtype's current definition of

  • True: attempt dtype conversion on all column (and refactor to use infer_dtype instead of astype guessing)
  • False: perform no dtype conversion
  • dict: dict keys that match column labels will be cast to type in the dict value
@mroeschke mroeschke added Dtype Conversions Unexpected or buggy dtype conversions IO JSON read_json, to_json, json_normalize Deprecate Functionality to remove in pandas labels Jul 1, 2024
@mroeschke mroeschke changed the title DEPR: Dtype casting in read_json DEPR: keep_default_dates and convert_dates in read_json Jul 1, 2024
@Animesh-Shukla
Copy link

taking this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Dtype Conversions Unexpected or buggy dtype conversions IO JSON read_json, to_json, json_normalize
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mroeschke @Animesh-Shukla