Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(polars): fix fmt_percent issue with polars-u64-idx #388

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

lostmygithubaccount
Copy link
Contributor

Summary

drive-by attempt at solving the issue I created. I'm sure there's a cleaner way to write this, but it unblocks me. feel free to push to this PR/request changes/close in favor of a better solution!

Related GitHub Issues and PRs

closes #387

Checklist

@lostmygithubaccount lostmygithubaccount changed the title bug(polars): fix fmt_percent issue with polars-u74-idx bug(polars): fix fmt_percent issue with polars-u64-idx Jun 29, 2024
@machow machow requested a review from rich-iannone July 2, 2024 14:22
@machow
Copy link
Collaborator

machow commented Jul 2, 2024

IMO this can only help :p. Do you mind giving a little context on how a person gets to this polars install? (Do you install with a flag, or install a special pypi package?).

@rich-iannone do you mind reviewing? (seems okay to me, since it's a fallback behavior)

edit: oh wait, I see from the issue it's from installing https://pypi.org/project/polars-u64-idx/ . seems like into okay fix for now imo

@lostmygithubaccount
Copy link
Contributor Author

yep for context, Polars as pip install polars doesn't work on ~>4.2 billion rows, so they have a separate polars-u64-idx you can install that has the same import: https://docs.pola.rs/user-guide/installation/#big-index

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.45%. Comparing base (793bd2a) to head (d5d07c9).

Files Patch % Lines
great_tables/_tbl_data.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   86.48%   86.45%   -0.04%     
==========================================
  Files          42       42              
  Lines        4685     4689       +4     
==========================================
+ Hits         4052     4054       +2     
- Misses        633      635       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rich-iannone
Copy link
Member

@machow a flake8 rule has been flagged here:

E722 do not use bare 'except'

@machow machow merged commit 6976cdd into posit-dev:main Jul 8, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fmt_percent doesn't work with polars-u64-idx
3 participants