Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Ticker.earnings #1977

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Deprecate Ticker.earnings #1977

merged 2 commits into from
Jul 13, 2024

Conversation

ValueRaider
Copy link
Collaborator

@ValueRaider ValueRaider commented Jul 5, 2024

The earnings chart on Yahoo website not available directly via API, have to get from income statement. Resolve #1948

Also remove some old deprecated code.

@ValueRaider ValueRaider marked this pull request as draft July 5, 2024 16:43
@ValueRaider ValueRaider changed the title DRAFT: deprecate Ticker.earnings Proposal: deprecate Ticker.earnings Jul 5, 2024
@ValueRaider ValueRaider changed the base branch from main to dev July 5, 2024 16:44
@ValueRaider ValueRaider marked this pull request as ready for review July 13, 2024 17:31
@ValueRaider ValueRaider changed the title Proposal: deprecate Ticker.earnings Deprecate Ticker.earnings Jul 13, 2024
@ValueRaider ValueRaider merged commit a73e974 into dev Jul 13, 2024
1 check passed
@ValueRaider ValueRaider deleted the fix/earnings branch July 13, 2024 17:46
@ValueRaider ValueRaider mentioned this pull request Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarterly_earnings & get_earning not working
1 participant