Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] - AST Support for fixed_point literals. #16118

Open
breta-nv opened this issue Jun 27, 2024 · 1 comment
Open

[FEA] - AST Support for fixed_point literals. #16118

breta-nv opened this issue Jun 27, 2024 · 1 comment
Labels
feature request New feature or request

Comments

@breta-nv
Copy link

breta-nv commented Jun 27, 2024

I wish I could use fixed_point literals in AST.

Our team utilizes compute_column, and we'd like to use fixed_point literals in the ast::expression. Without fixed_point, we have to rely on floating-point, which leads to incorrect results due to the usual precision and rounding errors.

Without AST support, we have to rely on a slower fallback path.

@breta-nv breta-nv added the feature request New feature or request label Jun 27, 2024
@JayjeetAtGithub
Copy link
Contributor

In #16088, I added support for fixed_point_scalar literals in AST here, which allows me to now pass fixed_point_scalar in an cudf::ast::operation. Although, the code compiles now, I am getting some weird behaviour when I am applying such an expression to cudf::compute_column.

So, basically, I have 2 filter expressions, each of them has a fixed_point_scalar. In one of them the value is 0.05 and in the other the value is 24. I am representing both these values as a fixed_point_scalar with a defined scale of -2 (same as my columns scale). The filter with 24 works correctly but the one with 0.05 does not. I am still trying to figure it out. But, I would like to know if anything is weird, or wrong that I am doing in this whole setup. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants