Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add single offset to an empty ListArray in cudf::to_arrow #16201

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Add single offset to an empty ListArray in cudf::to_arrow #16201

merged 1 commit into from
Jul 8, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Closes #16164

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jul 5, 2024
@davidwendt davidwendt self-assigned this Jul 5, 2024
@davidwendt
Copy link
Contributor Author

@wence- Just checking if this is compatible with #16198

@wence-
Copy link
Contributor

wence- commented Jul 5, 2024

I think so, yes

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jul 5, 2024
@davidwendt davidwendt changed the title Add zero offset to ListArray in cudf::to_arrow Add single offset to an empty ListArray in cudf::to_arrow Jul 5, 2024
@davidwendt davidwendt marked this pull request as ready for review July 5, 2024 16:47
@davidwendt davidwendt requested a review from a team as a code owner July 5, 2024 16:47
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2664427 into rapidsai:branch-24.08 Jul 8, 2024
81 checks passed
@davidwendt davidwendt deleted the empty-list-to-arrow branch July 8, 2024 18:00
@wence- wence- mentioned this pull request Jul 15, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@ttnghia ttnghia ttnghia approved these changes

@JayjeetAtGithub JayjeetAtGithub JayjeetAtGithub approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] make_lists_column does not enforce arrow-compatible invariants on offsets column
5 participants
@davidwendt @wence- @bdice @ttnghia @JayjeetAtGithub