Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove memory resource parameter from cudf::io::write_csv and cudf::io::write_json() APIs #16200

Closed
davidwendt opened this issue Jul 5, 2024 · 0 comments · Fixed by #16231
Closed

Remove memory resource parameter from cudf::io::write_csv and cudf::io::write_json() APIs #16200

davidwendt opened this issue Jul 5, 2024 · 0 comments · Fixed by #16231
Assignees
@JayjeetAtGithub
Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.

Comments

@davidwendt
Copy link
Contributor

Neither cudf::io::write_csv nor cudf::io::write_json() return any data to the caller so the passed in memory resource should never be used. https://github.com/rapidsai/cudf/blob/branch-24.08/cpp/doxygen/developer_guide/DEVELOPER_GUIDE.md#temporary-memory

Also, both the cudf::io::write_orc() and cudf::io::write_parquet() do not have memory resource parameters.
https://docs.rapids.ai/api/libcudf/stable/group__io__writers
@davidwendt davidwendt added libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function cuIO cuIO issue labels Jul 5, 2024
@davidwendt davidwendt mentioned this issue Jul 5, 2024
Merged
3 tasks
@JayjeetAtGithub JayjeetAtGithub self-assigned this Jul 9, 2024
@JayjeetAtGithub JayjeetAtGithub mentioned this issue Jul 9, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Jul 10, 2024
@JayjeetAtGithub
Remove mr param from write_csv and write_json (#16231)
64e3e8d 
Fixes #16200

Authors:
  - Jayjeet Chakraborty (https://github.com/JayjeetAtGithub)
  - Vukasin Milovanovic (https://github.com/vuule)

Approvers:
  - Vukasin Milovanovic (https://github.com/vuule)
  - Bradley Dice (https://github.com/bdice)

URL: #16231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JayjeetAtGithub JayjeetAtGithub

Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
cuDF/Dask/Numba/UCX
Status: Done
libcudf
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove mr param from write_csv and write_json JayjeetAtGithub/cudf
2 participants
@JayjeetAtGithub @davidwendt