Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Simplify LogVirtualView #46390

Open
alanwguo opened this issue Jul 2, 2024 · 2 comments · Fixed by #46391
Open

[Dashboard] Simplify LogVirtualView #46390

alanwguo opened this issue Jul 2, 2024 · 2 comments · Fixed by #46391
Labels
good first issue Great starter issue for someone just starting to contribute to Ray observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling

Comments

@alanwguo
Copy link
Contributor

alanwguo commented Jul 2, 2024

LogVirtualView component is very complex and utilizes react-window.

I think a simple component that just renders log lines directly into the DOM with the correct usage of memoization will have better performance and a better user behavior.

With react-window, log lines get re-rendered every time a user scrolls. This can be slow for large log files.

A browser can render many megabytes of text with no problem. But constantly re-rendering and re-layouting with scrolling can be very slow.

@alanwguo alanwguo added good first issue Great starter issue for someone just starting to contribute to Ray observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling labels Jul 2, 2024
@anyscalesam
Copy link
Collaborator

@alanwguo beyond that first issue are there additional improvements?

@alanwguo
Copy link
Contributor Author

alanwguo commented Jul 2, 2024

Main benefits are:

  1. Improved performance
  2. Better support for copy-paste. Can copy-paste all the content instead of just the visible text.
  3. simplify the code for easier maintenance.

@alanwguo alanwguo reopened this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Great starter issue for someone just starting to contribute to Ray observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants