Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken log viewer when multi-line logs are printed #46391

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

alanwguo
Copy link
Contributor

@alanwguo alanwguo commented Jul 2, 2024

Why are these changes needed?

Fixes bug where multi line logs will overlap with each other by making each log line only take up a single line. (Don't print new lines).

To view multi-line logs. A user can click into a log line and see it printed in a good format.

Screenshot 2024-07-02 at 12 23 50 PM
Screenshot 2024-07-02 at 12 23 55 PM

Related issue number

fixes #46371

In the future we should fix #46390. react-window is doing more harm than good here.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alan!

@alanwguo alanwguo added the go add ONLY when ready to merge, run all tests label Jul 2, 2024
@rkooo567 rkooo567 merged commit bcf53a4 into ray-project:master Jul 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard] Simplify LogVirtualView [Dashboard] Fix dashboard log viewer overflow
3 participants