Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLLib] Want to update PolicyClient and PolicyServerInput to the new API stack #46430

Open
ajlangley opened this issue Jul 3, 2024 · 1 comment
Labels
enhancement Request for new feature and/or capability P2 Important issue, but not time-critical rllib RLlib related issues rllib-client-server Issue related to RLlib's client/server API. rllib-newstack

Comments

@ajlangley
Copy link

Description

My understanding is that PolicyServerInput and PolicyClient don't work with the new API stack, which appears to be due to their use of the older RolloutWorker instead of EnvRunners.

The ability to hook in non-gym environments using this interface has been very valuable to me so far, and I'm interested in making an attempt to update these modules so that we can use the latest algorithms with them.

Currently, I have identified that mainly PolicyServer itself will need some updating, in addition to IOContext (it currently only takes a RolloutWorker in its __init__ method).

My main question about this is, could I get some general guidance on how to update the modules in question without making breaking changes to other parts of the project? My main concern is that IOContext could touch other code, although I'm relatively sure that PolicyServerInput and PolicyClient can be updated without causing issues elsewhere.

Thank you in advance for considering my request!

Use case

The PolicyServerInput feature is really useful for cases in which wrapping the environment in a gym interface is difficult. It would be nice to make sure it gets updated to the new API stack so everyone can continue using it.

@ajlangley ajlangley added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jul 3, 2024
@anyscalesam anyscalesam added the rllib RLlib related issues label Jul 8, 2024
@simonsays1980
Copy link
Collaborator

@ajlangley Thanks for raising this issue. The PolicyClient and PolicyServer is definitely on our list to have, but before the Summit 2024 there is no chance to get to this nor guide you in it as the list is already quite full for us. We will come back to this after the Summit.

@simonsays1980 simonsays1980 added rllib-client-server Issue related to RLlib's client/server API. rllib-newstack P2 Important issue, but not time-critical and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for new feature and/or capability P2 Important issue, but not time-critical rllib RLlib related issues rllib-client-server Issue related to RLlib's client/server API. rllib-newstack
Projects
None yet
Development

No branches or pull requests

3 participants