Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress for re-write of dataframe-go? #67

Open
winston-p opened this issue Sep 8, 2022 · 14 comments
Open

Progress for re-write of dataframe-go? #67

winston-p opened this issue Sep 8, 2022 · 14 comments

Comments

@winston-p
Copy link

It's written in the README file that "Once Go 1.18 (Generics) is introduced, the ENTIRE package will be rewritten.", As Go 1.18 has been released for a while, I'm wondering if work has started on re-writing of the entire package. If so, how's the progress?

@pjebs
Copy link
Collaborator

pjebs commented Sep 8, 2022

I'm still thinking about the best way to rewrite it. Looking for suggestions and help

@winston-p
Copy link
Author

I see. Perhaps you could detail some of your thoughts and ideas so far? I'm fairly new to Go but I'm sure others more experienced than me can chime in and/or offer help.

@pjebs
Copy link
Collaborator

pjebs commented Sep 9, 2022

Do you want to have a zoom chat?

@amlwwalker
Copy link

Would love to see this working with generics (and possibly be able to import a python pandas dataframe would be excellent). Happy to be involved to help with any thought process as this will be a game changer for Go!

@pjebs
Copy link
Collaborator

pjebs commented Oct 25, 2022

@amlwwalker Let me know if you want to help. My vision for how to add generics came undone when I learnt that you can't have generic methods: You can have generic functions obviously. But for some reason no generic methods.

@amlwwalker
Copy link

@pjebs does this not work? https://stackoverflow.com/a/70668559/1414721

can you give an example of a situation where that wouldn't cover the use case?

@pjebs
Copy link
Collaborator

pjebs commented Oct 26, 2022

type x struct {

}

func (s *x)[X any, Y any, D any] MyFunc(a X, b Y) D { // not allowed

}

@amlwwalker
Copy link

Does this not help?
https://stackoverflow.com/a/71378366/1414721

So each struct will need the method available on it, (could that be generated?) but you can then use an interface?

@pjebs
Copy link
Collaborator

pjebs commented Oct 27, 2022

Do you want to discuss over Zoom?

@amlwwalker
Copy link

happy to - I'm not very familiar with Go generics so I am probably not so useful to you, but if you want to talk it through with someone happy to be a sounding board. Got to get some stuff done right now, but can plan?

@pjebs
Copy link
Collaborator

pjebs commented Oct 27, 2022

send me an email with your availability: [email protected]

@agaddis02
Copy link

wanted to ping this thread again @pjebs are you still working on a rewrite?

@SaikyoSaru
Copy link

SaikyoSaru commented Feb 21, 2024

Bump on the above @pjebs, I would like to help out if you need a hand :)

@rocketlaunchr-cto
Copy link
Contributor

rocketlaunchr-cto commented Feb 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants