Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow fails when cron is running if using business hours to calculate WF actions #10453

Open
JackBuchanan opened this issue Jun 16, 2024 · 0 comments
Labels
Area: Workflow Issues & PRs related to all things regarding workflow Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Severity: Moderate Key function failed, but no or little impact Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Type: Bug Bugs within the core SuiteCRM codebase

Comments

@JackBuchanan
Copy link
Contributor

Issue

When using business hours to calculate date in workflow a 500 error is thrown when running from cron:

[16-Jun-2024 15:12:15 UTC] PHP Fatal error: Uncaught TypeError: AOBH_BusinessHours::addBusinessHours(): Argument #2 ($date) must be of type ?DateTime, bool given, called in /var/www/SuiteCRMCorePR/modules/AOW_Actions/actions/actionCreateRecord.php on line 279 and defined in /var/www/SuiteCRMCorePR/modules/AOBH_BusinessHours/AOBH_BusinessHours.php:185
Stack trace:
#0 /var/www/SuiteCRMCorePR/modules/AOW_Actions/actions/actionCreateRecord.php(279): AOBH_BusinessHours->addBusinessHours()
#1 /var/www/SuiteCRMCorePR/modules/AOW_Actions/actions/actionCreateRecord.php(170): actionCreateRecord->set_record()
#2 /var/www/SuiteCRMCorePR/modules/AOW_WorkFlow/AOW_WorkFlow.php(1046): actionCreateRecord->run_action()
#3 /var/www/SuiteCRMCorePR/modules/AOW_WorkFlow/AOW_WorkFlow.php(214): AOW_WorkFlow->run_actions()
#4 /var/www/SuiteCRMCorePR/modules/AOW_WorkFlow/AOW_WorkFlow.php(198): AOW_WorkFlow->run_flow()
#5 /var/www/SuiteCRMCorePR/modules/Schedulers/_AddJobsHere.php(836): AOW_WorkFlow->run_flows()
#6 /var/www/SuiteCRMCorePR/modules/SchedulersJobs/SchedulersJob.php(529): processAOW_Workflow()
#7 /var/www/SuiteCRMCorePR/include/SugarQueue/SugarCronJobs.php(191): SchedulersJob->runJob()
#8 /var/www/SuiteCRMCorePR/include/SugarQueue/SugarCronJobs.php(233): SugarCronJobs->executeJob()
#9 /var/www/SuiteCRMCorePR/cron.php(100): SugarCronJobs->runCycle()
#10 {main}
thrown in /var/www/SuiteCRMCorePR/modules/AOBH_BusinessHours/AOBH_BusinessHours.php on line 185

Possible Fix

No response

Steps to Reproduce the Issue

1. Create Workflow
2. Create Action where the business hours is used to calculate date field e.g. Date Created -> Date -> Date Created -> + -> 5 Business Hours
3. Run WF via cron

Context

No response

Version

7.14.2

What browser are you currently using?

Chrome

Browser Version

No response

Environment Information

php 8.2

Operating System and Version

Ubuntu 22

@JackBuchanan JackBuchanan added the Type: Bug Bugs within the core SuiteCRM codebase label Jun 16, 2024
JackBuchanan added a commit to JackBuchanan/SuiteCRM that referenced this issue Jun 16, 2024
…rs to calculate date

Use fixUpFormatting to correct date formats
@johnM2401 johnM2401 added Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Area: Workflow Issues & PRs related to all things regarding workflow Severity: Moderate Key function failed, but no or little impact Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Workflow Issues & PRs related to all things regarding workflow Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Severity: Moderate Key function failed, but no or little impact Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Type: Bug Bugs within the core SuiteCRM codebase
Projects
None yet
Development

No branches or pull requests

2 participants