Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Emoji Integration into the quotes #238

Open
shravan20 opened this issue Sep 21, 2023 · 4 comments
Open

feat: Emoji Integration into the quotes #238

shravan20 opened this issue Sep 21, 2023 · 4 comments
Labels
backend Backend related changes enhancement New feature or request frontend Frontend related changes / UI changes hacktoberfest help wanted Extra attention is needed Little work This task takes little time to complete. (ETA couple of days)

Comments

@shravan20
Copy link
Owner

Is your feature request related to a problem? Please describe.
Currently, no support for emojis

Describe the solution you'd like
Provide support for emojis in the github readme quotes on the card.
@shravan20 shravan20 added enhancement New feature or request help wanted Extra attention is needed Little work This task takes little time to complete. (ETA couple of days) hacktoberfest frontend Frontend related changes / UI changes backend Backend related changes labels Sep 21, 2023
@renzigpp
Copy link
Contributor

renzigpp commented Oct 4, 2023

Hi @shravan20, could you please provide some additional information? It seems that you can already use emojis in quotes (screenshot). What's the expected behavior?

image

image

@Adidem23
Copy link
Contributor

Please assign this issue to me

@Adidem23 Adidem23 mentioned this issue Oct 24, 2023
Merged
@shravan20
Copy link
Owner Author

could you please provide some additional information? It seems that you can already use emojis in quotes (screenshot). What's the expected behavior?

@GRenziITDM @Adidem23 : Want to populate emoji in existing quotes itself, as an optional bit, filter string without emoji by deafult and includes, only if enabled via query strings.

@Adidem23
Copy link
Contributor

Yeah I have populated strings with emoji which were there in json file . Now you can filter strings without emoji and populate them with emojis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Backend related changes enhancement New feature or request frontend Frontend related changes / UI changes hacktoberfest help wanted Extra attention is needed Little work This task takes little time to complete. (ETA couple of days)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@renzigpp @shravan20 @Adidem23