Fix typing for FastAPI add api route #10240
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10236
Make typing of endpoint parameter consistent with downstream calls and other utilities.
Justification for picking
Callable[..., Any]
over original:FastAPI.add_api_route
makes a direct call toAPIRouter.add_api_route
anywaysfastapi.dependencies.utils.get_typed_return_annotation
has signaturedef get_typed_return_annotation(call: Callable[..., Any]) -> Any:
FastAPI.add_api_websocket_route
)route_class: Type[APIRoute]
of whichfastapi.routing.APIRoute
subclassesstarlette.routing.Route
which also typesendpoint
withCallable[..., typing.Any]