Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradio 4 #14184

Open
wants to merge 74 commits into
base: dev
Choose a base branch
from
Open

Gradio 4 #14184

wants to merge 74 commits into from

Conversation

AUTOMATIC1111
Copy link
Owner

@AUTOMATIC1111 AUTOMATIC1111 commented Dec 3, 2023

Gradio 4 update.

The update breaks a lot of compatibility, some for very questionable reasons. Among other things, this branch makes it again possible to send bogus keyword arguments to components, and only get a warning for it, and use a _js argument for events. Basic functionality works, some extensions I have enabled like imagenet and tagcomplete load.

@daswer123
Copy link
Collaborator

daswer123 commented Dec 4, 2023

Hi, can you tag me when img2img is working? I will try to fix canvas-zoom-and-pan

@catboxanon catboxanon linked an issue Dec 4, 2023 that may be closed by this pull request
1 task
@missionfloyd
Copy link
Collaborator

@daswer123 Basic img2img is working. Still need to fix sketch, inpaint, etc.

@daswer123
Copy link
Collaborator

Yeah, thanks, in general everything is more or less for build-in "canvas-zoom-and-pan", a number of features will have to be abandoned because it is no longer needed, some will have to be redone.

@AUTOMATIC1111
Copy link
Owner Author

Oh, nice, there's been some work on this. Thanks. I couldn't do any myself because I was too busy.

@AlUlkesh
Copy link
Contributor

AlUlkesh commented Dec 14, 2023

fwiw - as far as extensions go, while testing the Image Browser extension, I ran into ASGI errors, when many events were triggered. I addressed this with the Gradio team and it is fixed in Gradio 4.9.0.

@w-e-w
Copy link
Collaborator

w-e-w commented Dec 15, 2023

fwiw - as far as extensions go, while testing the Image Browser extension, I ran into ASGI errors, when many events were triggered. I addressed this with the Gradio team and it is fixed in Gradio 4.9.0.

so bump to gradio 4.9.1?

@richrobber2
Copy link

i want to check and see how long we have until this gets into main branch do we have an eta?

@AUTOMATIC1111
Copy link
Owner Author

AUTOMATIC1111 commented Mar 31, 2024

Probably when they fix the bug with image inputs. Gradio 4 is a sad affair. It very likely will break extensions big time. Ooba updated to 4 and then reverted.

Edit: actually looks like he updated 4 days ago: oobabooga/text-generation-webui@2a92a84

@catboxanon
Copy link
Collaborator

Image editor issues should be fixed as of 4.27.0 now. https://github.com/gradio-app/gradio/releases/tag/gradio%404.27.0

@missionfloyd
Copy link
Collaborator

missionfloyd commented Apr 21, 2024

That seems to fix the send image buttons.

@w-e-w
Copy link
Collaborator

w-e-w commented Apr 22, 2024

ya auto's issue post is closed

@huchenlei
Copy link
Contributor

Is there any timeline when gradio 4.0 update will be ready?

@huchenlei
Copy link
Contributor

I am testing sd-webui-controlnet against gradio4 setup. However, a bunch of front-end issue seems to occur whenever I interact with almost anything on the extension UI. Any idea on this?

image

@AUTOMATIC1111
Copy link
Owner Author

I don't know when I will merge this in. With SD3, it definitely should be after that.

I also want to get some info about which big extensions this breaks, and possibly fix compatibility issues from our side.

@FurkanGozukara

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Upgrade to Gradio 4.0+
10 participants