-
Notifications
You must be signed in to change notification settings - Fork 26k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag --use-mime-file-filtering-for-batch-from-dir
#15819
base: dev
Are you sure you want to change the base?
Conversation
Additional changes seem good, but is it really needed to do the mime thing? its more code complexity, more libraries to depend on, and filesystem activity (to guess file type from content) and, as I see it, almost on benefit. |
Guessing filerype by its extension is very unreliable. Ar least in Linux world every program uses 'file' command to figure out its format, so there are a lot of files with no extension, and I get used to it E.g. KDE's Dolphin and Gwenview are filemanager, and do not take a notice on extensions |
I'd rather not read the file to find out of it's an image or not unless there really a call for that from users. |
It's optional |
Hm, is it good idea to move filetype package from requiraments.txt into somewhere else, and install it only of it's required? |
@AUTOMATIC1111 I have made an update. Now I install I didn't test it, because I cant, but looks like I did everything correctly |
d0c25b5
to
de16e85
Compare
force-pushed = rebased to the last dev |
Description
Adds flag
--use-mime-file-filtering-for-batch-from-dir
. Allows passing images with no or with incorrect extension in batch from directoryAlso I've fixed a bug when check requirements ignores requirements with no version
And also shared the img2img images walk logic with Extras/Batch from dir, instead of list of files
Checklist: