-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: feature/Labels subgroups #5770
Open
FrsECM
wants to merge
5
commits into
HumanSignal:develop
Choose a base branch
from
FrsECM:feature/label-subgroups
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
/jira create
|
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
Often, we need more than one class when we annotate image. There can also be some group of labels that have a meaning.
For example, let's take the example of the plane image :
![image](https://private-user-images.githubusercontent.com/26071804/324773673-f694305c-ee16-4447-b776-453e2f8e9c54.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExNTgwMjYsIm5iZiI6MTcyMTE1NzcyNiwicGF0aCI6Ii8yNjA3MTgwNC8zMjQ3NzM2NzMtZjY5NDMwNWMtZWUxNi00NDQ3LWI3NzYtNDUzZTJmOGU5YzU0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE2VDE5MjIwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU1YzJkNmU0NzM0NjIyNzQ4MDkwOTU4MzQwYzNjMzI4MGNhODg0MjI4MTBiMzY5ZTYzNTUwNTFkMDhhYzZiNmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.1WuqBZ0JL3hYQj3EQIqyqRPhXzL78Ybi2EUdW64qH1I)
The plane can be white/red, Boeing/Airbus.
It can have only one color and only one manufacturer.
What does this fix?
With this fix, we are able to group labels in subgroups.
![image](https://private-user-images.githubusercontent.com/26071804/324774491-9dde23cb-6e60-4d11-9acf-3e410425f25f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExNTgwMjYsIm5iZiI6MTcyMTE1NzcyNiwicGF0aCI6Ii8yNjA3MTgwNC8zMjQ3NzQ0OTEtOWRkZTIzY2ItNmU2MC00ZDExLTlhY2YtM2U0MTA0MjVmMjVmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE2VDE5MjIwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ2NDc4YWYxZDVjZjFjMWRlZjFmNzk2MDZiNDVhMDgwMmU1ZTYwNjQzYzI3YWJjM2ViMTMyNmRiYTM0ODg5NDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.eaeiAl8lCSwG0a7mf71djVk4pvarLduA40K41nIeyok)
In this case, we will group labels in combo-boxes.
What is the new behavior?
The UI will automatically group labels in subgroup.
If we activate mode "multiple" :
If we activate mode "subgroup":
labelstudio_car_example.mp4
What is the current behavior?
It will unpack all options and it will be complicate to identify main and subgroups.
What libraries were added/updated?
None
Does this change affect performance?
No
Does this change affect security?
No
What alternative approaches were there?
It would have been possible to create a complex taxonomy but it's much more impactful.
What feature flags were used to cover this change?
???
Does this PR introduce a breaking change?
(check only one)
For me it's not a major change because the old behavior is not impacted.
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
It will allow to annotate more precisely when we have "nested" classes on an object.