-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: jsonL support #5830
base: develop
Are you sure you want to change the base?
feat: jsonL support #5830
Conversation
Signed-off-by: George <[email protected]>
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: label_studio/data_import/models.py
Did you find this useful? React with a 👍 or 👎 |
/jira create
|
…trat as jsonL Signed-off-by: George <[email protected]>
After that pr I'm going to add
|
thanks for the PR @Jorjeous, our team is working through some PRs and we'll have a review for this one soon, thanks for being patient! related reports for jsonL support: |
for line in content: | ||
task_data = json.loads(line) | ||
|
||
if 'audio_filepath' in task_data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is it? It shouldn't be depended on any specific keys in task.data
# Upload audio to LS file storage | ||
with open(audio_path, 'rb') as audio_file: | ||
# Create a FileUpload for the audio | ||
audio_upload = create_file_upload(self.user, self.project, SimpleUploadedFile(os.path.basename(audio_path), audio_file.read())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It most cases LS doesn't have an access to audio_path, because it's deployed on a separated machine/docker
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
(link to issue, supportive screenshots etc.)
People often confuse json and jsonL
The nemo framework deliberately uses the name json, although in fact it is jsonL
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
Ability to import jsonL
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
No
Does this change affect performance?
(if so describe the impacts positive or negative)
No
Does this change affect security?
(if so describe the impacts positive or negative)
No
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)
Data import