WIP: implement sret_union
ABI for pointer-ful types
#55045
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively expands our existing
union
ABI to cover both of these existing cases:sret
ABI (which can stack-allocate a single pointer-ful type)union
ABI (which can stack-allocate many pointer-free types)This provides some nice speed-ups for temporary "wrappers":
On this PR this gives:
compared to current master:
TODO:
The most outstanding TODO here is what to do about ϕ-nodes. Right now, if the incoming
Union{...}
type has a pointer-containing type then this change forces the incoming object to be boxed, even if the object at run-time is actually pointer-free.But that's just a band-aid so the code works - it introduces new boxes where we didn't have them before, which is a regression that almost certainly needs to be fixed before landing this.