Support unified checkpoint for expert_parallel #8591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8591 +/- ##
===========================================
+ Coverage 53.86% 55.74% +1.88%
===========================================
Files 620 620
Lines 97110 96741 -369
===========================================
+ Hits 52306 53930 +1624
+ Misses 44804 42811 -1993 ☔ View full report in Codecov by Sentry. |
DesmonDay
force-pushed
the
moe_add_uc
branch
2 times, most recently
from
6415e4c
to
92d5432
Compare
DesmonDay
changed the title
ZHUI
reviewed
Jul 10, 2024
| @@ -22,6 +22,7 @@ | |||
| import paddle | |||
| import paddle.distributed as dist | |||
| from paddle.distributed import fleet | |||
| from paddle.framework import core | |||
There was a problem hiding this comment.
这个最好加个测试，框架可能需要有个模型支持一下expert_parallel
| if model_state_dict[key_name[0]].dtype != core.VarDesc.VarType.FP32: | ||
| key_name = "_".join([static_name, FP32_MASTER, key_name[1]]) | ||
| else: | ||
| key_name = "_".join([static_name, key_name[1]]) |
|
|
||
| need_files = set() | ||
| state_dict = get_expected_state_dict(model) | ||
| for key in state_dict.keys(): | ||
| filename = index["weight_map"][key] | ||
| # When using expert parallel, there's no need to check tensors with `no_sync=False` when dp_rank > 0. | ||
| if args.use_expert_parallel and dp_rank > 0 and not getattr(state_dict[key], "no_sync", False): |
| @@ -962,6 +1015,7 @@ def save_single_card_optimizer(args, model, optimizer, output_dir): | |||
| if master_weights is not None: | |||
| for key in list(master_weights.keys()): | |||
| master_weights[static2struct_name_mappings[key]] = master_weights.pop(key) | |||
| master_weights.update(fp32_weight) | |||
| else: | ||
| shard_file = file_name.replace( | ||
| ".pdparams", | ||
| f"-{args.logical_process_index + 1:05d}-of-{args.world_size//args.dataset_world_size:05d}.pdparams", |
| ) | ||
| shard_file = shard_file.replace( | ||
| ".safetensors", | ||
| f"-{args.logical_process_index + 1:05d}-of-{args.world_size//sd_degree:05d}.safetensors", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Support unified checkpoint for expert_parallel.