Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix #8620

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

bug fix #8620

wants to merge 1 commit into from

Conversation

wtmlon
Copy link
Collaborator

@wtmlon wtmlon commented Jun 18, 2024

PR types

PR changes

Description

修复 max_steps > epoch_steps 的计算错误问题

Copy link

paddle-bot bot commented Jun 18, 2024

Thanks for your contribution!

Copy link
Contributor

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.41%. Comparing base (307960c) to head (33182a9).
Report is 1 commits behind head on develop.

Files Patch % Lines
paddlenlp/trl/trl_utils.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8620      +/-   ##
===========================================
- Coverage    54.41%   54.41%   -0.01%     
===========================================
  Files          632      632              
  Lines        99481    99484       +3     
===========================================
  Hits         54132    54132              
- Misses       45349    45352       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants