fix unimo bug #8653
Open
fix unimo bug #8653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
|
DrownFish19
reviewed
Jun 26, 2024
| @@ -313,21 +313,21 @@ def __init__(self, hidden_size, vocab_size, activation, embedding_weights=None): | |||
| self.transform = nn.Linear(hidden_size, hidden_size) | |||
| self.activation = getattr(nn.functional, activation) | |||
| self.layer_norm = nn.LayerNorm(hidden_size) | |||
| self.decoder_weight = ( | |||
| self.weight = ( | |||
There was a problem hiding this comment.
此处不应修改参数名称，加载参数时需根据参数名称进行加载
There was a problem hiding this comment.
tie_weight方法的实现中，要求参数名称为weight，tie_weight
| def forward(self, hidden_states: Tensor, masked_positions: Optional[Tensor] = None): | ||
| if masked_positions is not None: | ||
| hidden_states = paddle.reshape(hidden_states, [-1, hidden_states.shape[-1]]) | ||
| hidden_states = paddle.tensor.gather(hidden_states, masked_positions) | ||
| hidden_states = self.transform(hidden_states) | ||
| hidden_states = self.activation(hidden_states) | ||
| hidden_states = self.layer_norm(hidden_states) | ||
| logits = paddle.tensor.matmul(hidden_states, self.decoder_weight, transpose_y=True) + self.decoder_bias | ||
| logits = paddle.tensor.matmul(hidden_states, self.weight, transpose_y=True) |
NINGBENZHE
reviewed
Jun 29, 2024
| @@ -349,6 +349,10 @@ def __init__(self, config: UNIMOConfig): | |||
| config.hidden_act, | |||
| self.unimo.embeddings.word_embeddings.weight, | |||
| ) | |||
| self.tie_weights() | |||
|
|
|||
| def get_output_embeddings(self): | |||
There was a problem hiding this comment.
这个方法只有一行代码，返回的还是类变量，没必要单独实现方法
There was a problem hiding this comment.
tie_weight方法的调用需要该方法的实现，tie_weight，同时请参考其他模型get_output_embeddings方法的实现。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
model
Description
fix bug unimo bug