Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vera-pissa method added #8722

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

TranscenderNing
Copy link

PR types

New features

PR changes

Add vera-pissa in peft/vera

Description

根据review意见修改

Copy link

paddle-bot bot commented Jul 5, 2024

Thanks for your contribution!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 73.49398% with 88 lines in your changes missing coverage. Please review.

Project coverage is 55.79%. Comparing base (d8ddba9) to head (92f8773).
Report is 1 commits behind head on develop.

Files Patch % Lines
paddlenlp/peft/vera/vera_model.py 71.14% 58 Missing ⚠️
paddlenlp/peft/vera/vera_layers.py 61.97% 27 Missing ⚠️
paddlenlp/peft/vera/vera_config.py 96.00% 2 Missing ⚠️
paddlenlp/trainer/integrations.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8722      +/-   ##
===========================================
+ Coverage    55.73%   55.79%   +0.05%     
===========================================
  Files          623      627       +4     
  Lines        97464    97792     +328     
===========================================
+ Hits         54324    54565     +241     
- Misses       43140    43227      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants