Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autogpt_builder): Add basic layout with nav #7317

Merged
merged 13 commits into from
Jul 9, 2024
Merged

feat(autogpt_builder): Add basic layout with nav #7317

merged 13 commits into from
Jul 9, 2024

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Jul 4, 2024 •
edited
Loading

Changes

  • Add basic app layout with nav
  • Move / to /build and set /build as default route (for now)
  • Fix /build + FlowEditor layout issues
  • Add mock /monitor page

screenshot of the new layout, showing the /build page

@netlify Netlify
Copy link

netlify bot commented Jul 4, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit f21c147
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/668d65167c9fa600083d47fc

@Pwuts Pwuts mentioned this pull request Jul 4, 2024
Merged
@Swiftyos
Copy link
Contributor

Swiftyos commented Jul 4, 2024 •
edited
Loading

Please can you add a screenshot please of the UI after these changes to the ticket description 🙏

(saw your screenshot and added it for you)

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@Pwuts Pwuts marked this pull request as draft July 4, 2024 17:36
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jul 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jul 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@Pwuts Pwuts marked this pull request as ready for review July 5, 2024 06:20
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jul 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 6, 2024

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jul 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 6, 2024

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jul 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

aarushik93
aarushik93 previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@aarushik93 aarushik93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can confirm that the reddit demo is working still, then I think this is ready to go

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@Torantulino
Copy link
Member

This appears to be working for me, tested basic flows and haven't observed any new bugs.

Torantulino
Torantulino requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@Torantulino Torantulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding as latest merge seems to have broken something

Torantulino
Torantulino approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@Torantulino Torantulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False alarm, LGTM

@Torantulino Torantulino merged commit 81dee56 into master Jul 9, 2024
11 checks passed
@Torantulino Torantulino deleted the reinier/open-1359-featautogpt_builder-create-basic-app-layout branch July 9, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftyos Swiftyos Swiftyos left review comments

@Torantulino Torantulino Torantulino approved these changes

@aarushik93 aarushik93 aarushik93 left review comments

@Bentlybro Bentlybro Awaiting requested review from Bentlybro

@kcze kcze Awaiting requested review from kcze

Assignees
No one assigned
Labels
size/xl
Projects
AutoGPT development kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pwuts @Swiftyos @Torantulino @aarushik93