Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autogpt_builder) Add animation effects nodes #7322

Closed
wants to merge 26 commits into from

Conversation

aarushik93
Copy link
Contributor

@aarushik93 aarushik93 commented Jul 4, 2024

Background

Setting up initial animation to show the user feedback, ie. when the node is queued, running, completed or failed

Need to update based on conflicts, from new changes in master

Changes πŸ—οΈ

Added CSS yelllow, green and red for queued, running, completed and failed.
Added CSS to show "motion"

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

Copy link
Contributor

github-actions bot commented Jul 4, 2024

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added conflicts Automatically applied to PRs with merge conflicts size/xl labels Jul 4, 2024
Copy link

netlify bot commented Jul 4, 2024

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit c9656a8
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/668c4cb579804700084ff55a

if (!current[keys[i]]) current[keys[i]] = {};
current = current[keys[i]];
}
current[keys[keys.length - 1]] = value;

Check warning

Code scanning / CodeQL

Prototype-polluting function Medium

The property chain
here
is recursively assigned to
current
without guarding against prototype pollution.
@aarushik93 aarushik93 changed the title Rushi/add animation effects nodes feat(autogpt_builder) Add animation effects nodes Jul 7, 2024
@aarushik93 aarushik93 force-pushed the rushi/add-animation-effects-nodes branch from f234e3f to c9656a8 Compare July 8, 2024 20:31
@aarushik93 aarushik93 closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Automatically applied to PRs with merge conflicts size/xl
Projects
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants