Fix #2429 config module

[fnielsen]

The setup and reading of the configuration is handle by a separate module.

Fixes #2429

Description

The setup and reading of the configuration is handle by a separate module.

Caveats

Please list anything which has been left out of this PR or which should be considered before this PR is accepted
Check any of the following which apply:

• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
  • I have made corresponding changes to the documentation
• This change requires new dependencies (please list)

If you make changes to the Python code

• My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

• Various tests on the command-line
• Test for the webapp, e.g., rss

Checklist

• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have not used code from external sources without attribution
• I have considered accessibility in my implementation
• There are no remaining debug statements (print, console.log, ...)

[egonw]

Okay, I think I see what you meant now.

My first test did not work, but that's because the scholia.js still uses internally hardcoded (unconfigurable) URLs. But I can work with this.

[egonw]

Example scholia.ini:

[query-server]
# QLever
#sparql_endpoint = https://qlever.cs.uni-freiburg.de/api/wikidata
#sparql_editurl = https://qlever.cs.uni-freiburg.de/wikidata/?query=
#sparql_embedurl = 

# OpenLink (Virtuoso)
#sparql_endpoint = https://wikidata.demo.openlinksw.com/sparql/
#sparql_editurl = 
#sparql_embedurl =

# Wikidata:
#sparql_endpoint = https://query.wikidata.org/sparql
#sparql_editurl = https://query.wikidata.org/#
#sparql_embedurl = https://query.wikidata.org/embed.html#

# Wikidata Split Main
sparql_endpoint = https://query-main-experimental.wikidata.org/sparql
sparql_editurl = https://query-main-experimental.wikidata.org/#
sparql_embedurl = https://query-main-experimental.wikidata.org/embed.html#

# Wikidata Split Scholar
#sparql_endpoint = https://query-scholarly-experimental.wikidata.org/sparql
#sparql_editurl = https://query-scholarly-experimental.wikidata.org/#
#sparql_embedurl = https://query-scholarly-experimental.wikidata.org/embed.html#

[requests]
user_agent = Scholia

[fnielsen]

I am trying to understand this. As far as I can determine you do not have polymorphic functions in Javascript, so the second definition of sparqlToResponse will overwrite the first one? Or what am I missing?

[fnielsen]

$ node -e "function f(a, b) { console.log('two arguments'); } function f(a) { console.log('one argument'); } f(1, 2);"
one argument

[egonw]

@fnielsen, good catch. Are you okay to name the new one sparqlToResponse2? If not, what name should it be?

[egonw]

Patch pushed: 4f593ae

[egonw]

@fnielsen, what do you think?