[PoC] Concurrent sources better parallelism #40735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
inossidabile
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
inossidabile
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
inossidabile
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
inossidabile
had a problem deploying
to
community-ci-auto
GitHub Actions
Failure
inossidabile
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
inossidabile
had a problem deploying
to
community-ci-auto
GitHub Actions
Failure
inossidabile
requested a deployment
to
community-ci
GitHub Actions
Waiting
inossidabile
requested a deployment
to
community-ci
GitHub Actions
Waiting
marcosmarxm
reviewed
Jul 5, 2024
There was a problem hiding this comment.
Thanks, @inossidabile. This will definitely lead to discussions how to improve performance. I'll ask the connector team to review and provide feedback on the changes you're proposing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is a proof of concept PR to suggest potential improvement of concurrency. While I was playing around with the concept of swapping
ThreadPooolExecutorforProcessPoolExecutor, I started seeing things. I wanted to change the orchestration just a little bit to reduce linking and make data serializable. And ProcessPoolExecutor kind of came for a change :).I understand it's a long shot, again. it's more of an informational PR. Thanks for your attention.
User Impact
MOAR LOAD CORES
Can this PR be safely reverted and rolled back?