Update error handling for source-amazon-seller-partner #40751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
maxi297
commented
Jul 5, 2024
...integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/streams.py
Show resolved
Hide resolved
bazarnov
approved these changes
Jul 8, 2024
darynaishchenko
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Partially addresses: https://github.com/airbytehq/airbyte-internal-issues/issues/8468
Update the error handling of source-amazon-seller-partner to avoid getting paged for non-actionable problems.
Also updated the releaseStage so that we start alerting on these.
How
Handle the most common errors I've seen in https://airbytehq.sentry.io/issues/5489728722, namely:
Review guide
airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/streams.pyUser Impact
In terms of the user, the streams will still fail as they were failing before but the errors will be categorized differently. In some cases, it seems like streams were not failing and we would simply
return []. In those cases, I added proper AirbyteTracedExceptionsCan this PR be safely reverted and rolled back?