Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(destination-pinecone): Replaced using AirbyteLogger with an AirbyteLogMessage instead #40753

Merged
merged 6 commits into from
Jul 7, 2024

Conversation

natikgadzhi
Copy link
Contributor

What

When handling an error, destination Pinecone attemted to use AirbyteLogger, which we removed before CDK 1.0, so that blew up.

This fix uses AirbyteLogMessage instead. I've also updated CDK to 2.0 while I'm here.

User Impact

When connector errors out, now it should capture the error instead of crashing.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@natikgadzhi natikgadzhi requested a review from a team as a code owner July 5, 2024 20:41
Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jul 7, 2024 9:50pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/pinecone labels Jul 5, 2024
@natikgadzhi
Copy link
Contributor Author

@aaronsteers I assume integration tests will run on CI, right?

@aaronsteers
Copy link
Collaborator

aaronsteers commented Jul 5, 2024

@aaronsteers I assume integration tests will run on CI, right?

I believe so...

There's a lot going on here, but I assume integration tests would run here:

https://github.com/airbytehq/airbyte/actions/runs/9813423151/job/27099424463

UPDATE: No. And I have no idea why.

image

My first guess was missing test config, but no, it looks like that is present:

connectorTestSuitesOptions:
- suite: unitTests
- suite: integrationTests
testSecrets:
- name: SECRET_DESTINATION-PINECONE__CREDS
fileName: config.json
secretStore:
type: GSM
alias: airbyte-connector-testing-secret-store
- suite: acceptanceTests
testSecrets:
- name: SECRET_DESTINATION-PINECONE__CREDS
fileName: config.json
secretStore:
type: GSM
alias: airbyte-connector-testing-secret-store
metadataSpecVersion: "1.0"

UPDATE (2): See below. Build fails from a Pydantic error, then other steps are skipped.

Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natikgadzhi - Looks like Pydantic 2.0 (aka CDK 2.0) breaks this.

RuntimeError: no validator found for <class 'destination_pinecone.config.PineconeIndexingModel'>, see `arbitrary_types_allowed` in Config

☝️ from the CI report.

@natikgadzhi
Copy link
Contributor Author

Yep, pinning to <2.

@natikgadzhi
Copy link
Contributor Author

natikgadzhi commented Jul 6, 2024

/format-fix

Format-fix job started... Check job output.

❌ Job failed.

@natikgadzhi
Copy link
Contributor Author

@aaronsteers ready. Fixing formatting and version, but tests should pass now.

@natikgadzhi
Copy link
Contributor Author

natikgadzhi commented Jul 6, 2024

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (3440df1)

Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks, @natikgadzhi! 🙏

@aaronsteers
Copy link
Collaborator

aaronsteers commented Jul 7, 2024

@natikgadzhi - I see another release landed last night with the same version number for this connector, which is blocking this one now. I will see if I can resolve the conflict real quick.

Update: Done!

@natikgadzhi natikgadzhi merged commit 2e8337e into master Jul 7, 2024
32 checks passed
@natikgadzhi natikgadzhi deleted the ng/destination-pinecone-logger-fix branch July 7, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/pinecone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants