Fix some naming issue on CAT client container logic #40755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
clnoll
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Thanks @xiaohansong, sorry I overlooked this. I added a commit to remove the print statement for the catalog, but if you want it to be emitted feel free to add a log line.
I also added a commit to remove the hardcoded dockerfile name.
| @@ -352,6 +352,7 @@ async def discovered_catalog_fixture( | |||
|
|
|||
| output = await docker_runner.call_discover(config=connector_config) | |||
| catalogs = [message.catalog for message in output if message.type == Type.CATALOG] | |||
| print(catalogs) | |||
There was a problem hiding this comment.
Suggested change
| print(catalogs) | |
| logging.info(catalogs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?