CDK: Add support for input format parsing at jinja macro format_datetime #40759
+18
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
cristina.mariscal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
girarda
approved these changes
Jul 5, 2024
airbyte-cdk/python/pyproject.toml
Outdated
| @@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api" | |||
|
|
|||
| [tool.poetry] | |||
| name = "airbyte-cdk" | |||
| version = "2.2.0" | |||
| version = "2.2.1" | |||
There was a problem hiding this comment.
you shouldn't need to bump the version. the github action will take care of it
| @@ -107,7 +107,7 @@ def duration(datestring: str) -> Union[datetime.timedelta, isodate.Duration]: | |||
| return parse_duration(datestring) # type: ignore # mypy thinks this returns Any for some reason | |||
|
|
|||
|
|
|||
| def format_datetime(dt: Union[str, datetime.datetime], format: str) -> str: | |||
| def format_datetime(dt: Union[str, datetime.datetime], format: str, input_format: str = None) -> str: | |||
There was a problem hiding this comment.
nit: input_format is an Optional[str]
added 2 commits
July 5, 2024 16:14
maxi297
approved these changes
Jul 5, 2024
bazarnov
approved these changes
Jul 6, 2024
bazarnov
approved these changes
Jul 6, 2024
| @@ -107,7 +107,7 @@ def duration(datestring: str) -> Union[datetime.timedelta, isodate.Duration]: | |||
| return parse_duration(datestring) # type: ignore # mypy thinks this returns Any for some reason | |||
|
|
|||
|
|
|||
| def format_datetime(dt: Union[str, datetime.datetime], format: str) -> str: | |||
| def format_datetime(dt: Union[str, datetime.datetime], format: str, input_format: Optional[str] = None) -> str: | |||
There was a problem hiding this comment.
There are errors for this test:
==================================== ERRORS ====================================
_ ERROR collecting airbyte-cdk/python/unit_tests/sources/declarative/interpolation/test_macros.py _
airbyte-cdk/python/unit_tests/sources/declarative/interpolation/test_macros.py::test_format_datetime: in "parametrize" the number of names (4):
['test_name', 'input_value', 'format', 'expected_output']
must be equal to the number of values (5):
('test_datetime_string_to_date', '2022-01-01T01:01:01Z', '%Y-%m-%d', None, '2022-01-01')
=============================== warnings summary ===============================
airbyte_cdk/connector_builder/connector_builder_handler.py:28
added 3 commits
July 8, 2024 02:12
…m-airbyte/macros_dt_str
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In order to support complex input datetime formats at low code, including input_format param to format_datetime macro, so it will allow us to parse any kind of datetime string, so it can be processed to standarized ISO (or any other format as required).
Review guide
Can this PR be safely reverted and rolled back?