Destination SFTP JSON: Migrate to base image + poetry #40760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
natikgadzhi
reviewed
Jul 6, 2024
| @@ -1,118 +1,91 @@ | |||
| # Sftp Json Destination | |||
| # Sftp-Json source connector | |||
There was a problem hiding this comment.
Hmmmm, I think you'd have to check out the old readme and manually change it. I think it also could be that we messed up other connectors like that too.
| python main.py spec | ||
| python main.py check --config secrets/config.json | ||
| python main.py discover --config secrets/config.json | ||
| python main.py read --config secrets/config.json --catalog integration_tests/configured_catalog.json |
There was a problem hiding this comment.
Lol, both the old and the new one are wrong.
| destination-sftp-json = "destination_sftp_json.run:run" | ||
|
|
||
| [tool.poetry.group.dev.dependencies] | ||
| pytest = "^6.1" |
There was a problem hiding this comment.
Suggested change
| pytest = "^6.1" | |
| pytest = "^8" |
|
|
||
| [tool.poetry.group.dev.dependencies] | ||
| pytest = "^6.1" | ||
| docker = "==5.0.3" |
There was a problem hiding this comment.
The new docker library is 7+, but there are cross-dependencies. It could be that it's better to migrate first and upgrade separately, this is rather high usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Migrates destination SFTP JSON to our base image and poetry
User Impact
No impact
Can this PR be safely reverted and rolled back?