Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hybrid executors in backfill jobs #40472

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

o-nikolas
Copy link
Contributor

The backfill job does its own scheduling and so needs changes to support hybrid executors outside of the Airflow Scheduler.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:Executors-core LocalExecutor & SequentialExecutor area:Scheduler Scheduler or dag parsing Issues labels Jun 27, 2024
@o-nikolas o-nikolas added full tests needed We need to run full set of tests for this PR to merge upgrade to newer dependencies If set, upgrade to newer dependencies is forced labels Jun 27, 2024
Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some non-blocking comments

airflow/exceptions.py Outdated Show resolved Hide resolved
airflow/jobs/backfill_job_runner.py Show resolved Hide resolved
airflow/jobs/backfill_job_runner.py Show resolved Hide resolved
@o-nikolas o-nikolas added AIP-61 Hybrid executors and removed full tests needed We need to run full set of tests for this PR to merge upgrade to newer dependencies If set, upgrade to newer dependencies is forced labels Jun 28, 2024
@o-nikolas o-nikolas marked this pull request as ready for review June 28, 2024 17:38
@kaxil kaxil added this to the Airflow 2.10.0 milestone Jun 29, 2024
@potiuk
Copy link
Member

potiuk commented Jul 3, 2024

Looks good. That's pretty non-obvious complexity with hybrid executors :)

@kaxil
Copy link
Member

kaxil commented Jul 9, 2024

@o-nikolas Can this be merged?

The backfill job does its own scheduling and so needs changes to support
hybrid executors outside of the Airflow Scheduler. The executor is
loaded (from a cache) for tasks as they are scheduled by the backfill
job.
@o-nikolas o-nikolas force-pushed the onikolas/aip-61/backfill_jobs branch from 40f57c9 to d7f03d0 Compare July 10, 2024 18:11
@o-nikolas o-nikolas merged commit 23b9add into apache:main Jul 10, 2024
52 checks passed
@o-nikolas o-nikolas deleted the onikolas/aip-61/backfill_jobs branch July 10, 2024 18:53
@utkarsharma2 utkarsharma2 added the type:new-feature Changelog: New Features label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-61 Hybrid executors area:Executors-core LocalExecutor & SequentialExecutor area:Scheduler Scheduler or dag parsing Issues type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants